Christian Walther wrote:Do we really need Crucible to review this and the other contributions that reviews were opened for today (15-19)? The changes are so simple that Bitbucket seems completely adequate to me, and we have already started reviewing them there. In my opinion, CWE-ou and MOULSCRIPT-ou are already hobbled enough by essentially having only a single maintainer (rarified), so I’d rather not see him bogged down by additional bureaucracy when he’s stretched thin already.
OK, if you don’t feel it’s a burden on you, then that already addresses most of my concern.rarified wrote:No we don't need Crucible on these, but I want to try to establish a standard location for people to see pending stuff going into the pipeline. Right now it's pretty cut-and-paste from BB comments to here; I need to extract the changes as a patch anyway to get them into the Minkata-specific repository, so applying the patch here as well gives a way of confirming the transfer was done correctly (if the author is inclined to visit Crucible and eyeball the changes).
I think a discussion of abbreviated process for some classes of changes should be a discussion in the forums, and would be happy to have a dialog about it.
However, I still think it’s a bit awkward to have things reviewed in two places. Some people will copy and paste their comments from one place to the other, which is extra work. Some will only comment in one place and miss what is being said in the other. It just doesn’t feel like a process as simple and inviting to contributors as it should be.
My preferred solution would be to keep review of contributions that come in as Bitbucket pull requests on Bitbucket, and only resort to Crucible when Bitbucket’s capabilities turn out to be insufficient (e.g. lack of comments on individual lines of code).
I see your point about having a single central point of entry, but in that case, I wonder, should we discourage Bitbucket pull requests and mandate that all contributions come in through Crucible, to avoid the duplication?
Is there an interest in this discussion from other involved people?